chore(deps): Bump PDF.js from 4.0.189 to 4.10.38 - #1474
Merged
Conversation
This was referenced Jul 16, 2026
danxuliu
force-pushed
the
bump-pdf.js-from-4.0.189-to-4.10.38
branch
2 times, most recently
from
August 9, 2026 17:40
7b7ef99 to
e5b3511
Compare
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The "viewer.php" acts as the "viewer.html" file included in the PDF.js package. This commit updates "viewer.php" with the changes to "viewer.html" from PDF.js 4.0.189 to 4.0.269 while respecting the customized parts of "viewer.php". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The "viewer.php" acts as the "viewer.html" file included in the PDF.js package. This commit updates "viewer.php" with the changes to "viewer.html" from PDF.js 4.0.269 to 4.0.379 while respecting the customized parts of "viewer.php". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The "viewer.php" acts as the "viewer.html" file included in the PDF.js package. This commit updates "viewer.php" with the changes to "viewer.html" from PDF.js 4.0.379 to 4.1.392 while respecting the customized parts of "viewer.php". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The "viewer.php" acts as the "viewer.html" file included in the PDF.js package. This commit updates "viewer.php" with the changes to "viewer.html" from PDF.js 4.2.67 to 4.3.136 while respecting the customized parts of "viewer.php". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Since PDF.js 4.4.168 a loading cursor is shown while the file is being saved. This is done by awaiting on the "save" function, so "handleSave" now needs to return its promise. This also blocks interacting with the viewer UI until saving the file finishes. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The "viewer.php" acts as the "viewer.html" file included in the PDF.js package. This commit updates "viewer.php" with the changes to "viewer.html" from PDF.js 4.4.168 to 4.5.136 while respecting the customized parts of "viewer.php". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Since PDF.js 4.5.136 the property "locale" was replaced with "localeProperties", which takes an object with a "lang" parameter. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The "viewer.php" acts as the "viewer.html" file included in the PDF.js package. This commit updates "viewer.php" with the changes to "viewer.html" from PDF.js 4.5.136 to 4.6.82 while respecting the customized parts of "viewer.php". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The "viewer.php" acts as the "viewer.html" file included in the PDF.js package. This commit updates "viewer.php" with the changes to "viewer.html" from PDF.js 4.6.82 to 4.7.76 while respecting the customized parts of "viewer.php". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The "viewer.php" acts as the "viewer.html" file included in the PDF.js package. This commit updates "viewer.php" with the changes to "viewer.html" from PDF.js 4.8.69 to 4.9.124 while respecting the customized parts of "viewer.php". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The "viewer.php" acts as the "viewer.html" file included in the PDF.js package. This commit updates "viewer.php" with the changes to "viewer.html" from PDF.js 4.9.124 to 4.9.155 while respecting the customized parts of "viewer.php". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
danxuliu
force-pushed
the
bump-pdf.js-from-4.0.189-to-4.10.38
branch
from
August 9, 2026 17:44
e5b3511 to
eb924f7
Compare
Member
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Member
Author
|
/backport to stable34 please |
Member
Author
|
/backport to stable33 please |
Member
Author
|
/backport to stable32 please |
Member
Author
|
The viewer CI check always fails when viewer.html is modified even if the viewer.php file is also properly adjusted (which it was), so it is not relevant. |
Member
Author
|
Exceptionally, as this has been extensively tested already, this pull request was merged without reviewer approval. |
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1265
Fixes #1116
Fixes #874
Fixes #636
Fixes #635
This is a step by step bump to better check the differences and be able to spot regressions and/or behaviour changes "easily".
Note that the annotation editor has been greatly improved, but unfortunately due to an upstream bug in some cases the Save button may not work reliably (it may not be enabled when needed, or it may be enabled without need).
Independently of that, the highlighter can be used on a text or freely on the document. However, to highlight a text interacting with the text layer is needed, which is not possible when the download is disabled on a shared PDF file (as in that case text selection is also disabled). In that case the text highlighter appears when the cursor is on a text, but dragging the cursor does not highlight anything. Unfortunately I did not find any way to disable just the text highlighter while allowing free highlighting, so both are kept when the download is disabled, even if the text highlighter does nothing in that case.